Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7600: Delete EIPS/eip-7212.md #8779

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Update EIP-7600: Delete EIPS/eip-7212.md #8779

merged 3 commits into from
Aug 21, 2024

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Aug 2, 2024

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@SamWilsn SamWilsn requested a review from eth-bot as a code owner August 2, 2024 15:39
@SamWilsn SamWilsn mentioned this pull request Aug 2, 2024
Closed
9 tasks
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 2, 2024 •
edited
Loading

File EIPS/eip-7600.md

Requires 1 more reviewers from @timbeiko

File EIPS/eip-7212.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @xinbenlv

@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Aug 2, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 2, 2024
ulerdogan
ulerdogan approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ulerdogan ulerdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes. Can you also consider removing related assets under assets/eip-7212? Opened a PR for that.

@ulerdogan ulerdogan mentioned this pull request Aug 2, 2024
Closed
@g11tech
Copy link
Contributor

g11tech commented Aug 3, 2024

Thanks for applying the changes. Can you also consider removing related assets under assets/eip-7212? Opened a PR for that.

i think assets also need to be deleted in same PR to make CI pass

@ulerdogan
Copy link
Contributor

Thanks for applying the changes. Can you also consider removing related assets under assets/eip-7212? Opened a PR for that.

i think assets also need to be deleted in same PR to make CI pass

My PR aims this PR's branch to delete the assets, so it can make CI pass after it's merged. @g11tech

@g11tech
Copy link
Contributor

g11tech commented Aug 5, 2024

Thanks for applying the changes. Can you also consider removing related assets under assets/eip-7212? Opened a PR for that.

i think assets also need to be deleted in same PR to make CI pass

My PR aims this PR's branch to delete the assets, so it can make CI pass after it's merged. @g11tech

PR won't be merged if any of the branches don't pass the CI, so both deletions need to be in same PR i guess

@ulerdogan
Copy link
Contributor

Thanks for applying the changes. Can you also consider removing related assets under assets/eip-7212? Opened a PR for that.

i think assets also need to be deleted in same PR to make CI pass

My PR aims this PR's branch to delete the assets, so it can make CI pass after it's merged. @g11tech

Ah understood, yes. I assume @SamWilsn is able to merge the PR, even if the CI does not pass. I wanted to help him by preparing the PR, thinking it's not dangerous as it's him branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

The commit 6bc8006 (as a parent of 3fbef24) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-meta labels Aug 21, 2024
@eth-bot eth-bot changed the title Delete EIPS/eip-7212.md Update EIP-7600: Delete EIPS/eip-7212.md Aug 21, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 21, 2024
@SamWilsn SamWilsn merged commit 0ab9c08 into master Aug 21, 2024
11 of 15 checks passed
@SamWilsn SamWilsn deleted the SamWilsn-patch-3 branch August 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulerdogan ulerdogan ulerdogan approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-review This EIP is in Review t-meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamWilsn @eth-bot @g11tech @ulerdogan